ci: use pnpm exec for playwright install to match lockfile version#415
Merged
ci: use pnpm exec for playwright install to match lockfile version#415
Conversation
`pnpm dlx playwright install` pulls the latest playwright CLI, which may download a different chromium revision than the one expected by the project's locked playwright version. This caused browser-related rstest examples to fail when the latest playwright (chromium v1217) diverged from the locked playwright@1.58.1 (chromium v1208). Switch to `pnpm exec playwright install --with-deps chromium` so the project's own playwright binary is used to download the matching browser. Amp-Thread-ID: https://ampcode.com/threads/T-019d4701-dfdb-73c6-a876-29ab299f63cf Co-authored-by: Amp <amp@ampcode.com>
fi3ework
changed the title
Amp-Thread-ID: https://ampcode.com/threads/T-019d4701-dfdb-73c6-a876-29ab299f63cf Co-authored-by: Amp <amp@ampcode.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bb8e35724
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pnpm dlx playwright install chromiumpulls the latest playwright CLI to download browsers. When the latest playwright version diverges from the project's locked version (playwright@1.58.1), the downloaded chromium revision won't match what@rstest/browserexpects at runtime.pnpm dlxdownloaded chromium v1217 (latest playwright)@rstest/browser(viaplaywright@1.58.1) expected chromium v1208This caused: https://github.com/rstackjs/rstack-examples/actions/runs/23829705206/job/69460295174
Fix
Use
pnpm exec playwright install --with-deps chromiumso the project's own locked playwright binary downloads the matching browser revision.